Fix crash in PatternMatcher for dependent type NamedTuple.From #24515
+13
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My understanding is that the test case in i24504 is expected to take this branch: https://github.com/scala/scala3/blob/0470ec1ff46a822ca58e204587fb67d56004623a/compiler/src/dotty/tools/dotc/transform/PatternMatcher.scala#L420 where we the info is comming from https://github.com/scala/scala3/blob/0470ec1ff46a822ca58e204587fb67d56004623a/compiler/src/dotty/tools/dotc/transform/PatternMatcher.scala#L118-L124 that has called `dropNamedTuple` https://github.com/scala/scala3/blob/0470ec1ff46a822ca58e204587fb67d56004623a/compiler/src/dotty/tools/dotc/transform/PatternMatcher.scala#L113-L115 the problem is that under this case the type will be `NamedTuple.From` for which `isNamedTupleType` returns false. Which means that the returned type will not be a `NonEmptyTupleType`. The fix in this mr adds a `normalized.dealias` call in `isNormalizedTupleType` which brings it inline with `stripNormalizedTupleType`. But seems feasible that a better fix could be that `NamedTuple.From` should have already been removed earlier. But it not clear to me if that possible. fixes: i24504
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My understanding is that the test case in i24504 is expected to take
this branch:
scala3/compiler/src/dotty/tools/dotc/transform/PatternMatcher.scala
Line 420 in 0470ec1
where we the info is comming from
scala3/compiler/src/dotty/tools/dotc/transform/PatternMatcher.scala
Lines 118 to 124 in 0470ec1
that has called
dropNamedTuplescala3/compiler/src/dotty/tools/dotc/transform/PatternMatcher.scala
Lines 113 to 115 in 0470ec1
the problem is that under this case the type will be
NamedTuple.Fromfor which
isNamedTupleTypereturns false. Which means that thereturned type will not be a
NonEmptyTupleType.The fix in this mr adds a
normalized.dealiascall inisNormalizedTupleTypewhich brings it inline withstripNormalizedTupleType. But seems feasible that a better fix couldbe that
NamedTuple.Fromshould have already been removed earlier. Butit not clear to me if that possible.
fixes: #24504